Don't enqueue submission job after fixing missing filenames#2011
Open
Don't enqueue submission job after fixing missing filenames#2011
Conversation
The dev running the task should retry the original failed job rather than enqueuing a new submission job. Otherwise the failed job will stay on the failed job queue and our alarms won't resolve.
Contributor
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2011.submit.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
The dev running the task should retry the original failed job rather than enqueuing a new submission job. Otherwise the failed job will stay on the failed job queue and our alarms won't resolve.
Things to consider when reviewing